Update Brotli size package #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping |
|
hi, @siddharthkp any chance you could take a look at this soon :) |
stefee
approved these changes
Jan 23, 2019
|
Any chance of this getting merged? This would save building |
|
@nikolaik |
|
✨ Nice! @srilq Is the NPM package intentionally private? |
|
@nikolaik |
|
@siddharthkp: can this be merged until #220 is done? We are stuck with an old version due to missing Node.js >=10 support. |
benjamn
added a commit
to apollographql/apollo-link
that referenced
this pull request
Mar 4, 2019
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 5, 2019
siddharthkp/bundlesize#260 (comment) Also using @condenast/bundlesize for the apollo-link packages: apollographql/apollo-link#965
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 6, 2019
siddharthkp/bundlesize#260 (comment) Also using @condenast/bundlesize for the apollo-link packages: apollographql/apollo-link#965
|
This is fixed now in |
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Sep 11, 2019
This reverts my previous PR #4538, now that siddharthkp/bundlesize#260 has been merged and published to npm.
StephenBarlow
pushed a commit
to apollographql/apollo-client
that referenced
this pull request
Oct 1, 2019
This reverts my previous PR #4538, now that siddharthkp/bundlesize#260 has been merged and published to npm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the
brotli-sizepackage to makebundlesizesuport node 10Motivation and Context
We depend on bundlesize and are looking to move to node 10. bundlesize use
brotli-sizewhich usesiltorb. The current version of iltorb that comes with bundlesize doesnt work with node 10.This PR simply updates the dependency so that we are unblocked from updating node to 10 (and so are others)
I noticed #220 to make brotli-size optional and that seems like a bigger effort. However, this is a simple upgrade and would love if we could get this in and out to unblock node 10 support
Screenshots (if appropriate):
NA
Types of changes
Checklist:
Fixes #261