Added new bundlesize-pipe executable, which accepts file contents fro… #91
Conversation
pipe.js
Outdated
| const debug = require('./src/debug') | ||
|
|
||
| if (Boolean(process.stdin.isTTY)) { | ||
| error('bundlesize-pipe executable is meant for usage with piped data.', { label: 'ERROR', exit: true }) |
There was a problem hiding this comment.
option obejct could be omitted if this gets released - https://github.com/siddharthkp/prettycli/pull/3/files
| @@ -15,7 +15,7 @@ config.map(file => { | |||
| } else { | |||
| paths.map(path => { | |||
| const size = gzip.sync(fs.readFileSync(path, 'utf8')) | |||
| const maxSize = bytes(file.threshold || file.maxSize) || Infinity | |||
| const maxSize = bytes(file.maxSize) || Infinity | |||
There was a problem hiding this comment.
i have not found how this .threshold could land here, its probably some deprecated (and removed) option
Andarist
force-pushed
the
accept-piped-stream
branch
from
9684dbc
to
3977678
Compare
|
Can you resolve package-lock.json and raise a fresh pull ? |
Andarist
force-pushed
the
accept-piped-stream
branch
from
3977678
to
ab0b893
Compare
|
@jagzviruz Ive rebased this one instead. So its quite fresh right now :) |
|
@Andarist You have one lint error 😟 /home/travis/build/siddharthkp/bundlesize/src/readStream.js |
…m the stdin stream (fixes siddharthkp#90)
Andarist
force-pushed
the
accept-piped-stream
branch
from
ab0b893
to
ab42076
Compare
|
@SaraVieira fixed, i believe this was introduced by some new rules which were not there when Ive created the PR |
|
@Andarist Very likely , I have updated a bunch of eslint rules a couple of weeks ago |
|
@SaraVieira @reznord thanks for merging :) whats ur release cycle, when I can expect to have this published? No rush ofc, just asking |
|
If everyone os okay with it I can do a minor release of this today |
|
Yup, go ahead! Once a version is released, just tag me here once so that I can test if the install is working fine and there is no issue like #130 |
|
@SaraVieira just pinging about the release :P |
|
@Andarist omg I am so sorry , I have been doing a 100 stuff and forgot , if you ever meet me in person I do owe you coffee or beer :( Published: |
|
@SaraVieira not a problem, i totally understand how it is to take too much on yourself |
|
Still if you ever in lisbon ping me and I shall get you coffee 🙌 Thank you for the ping and the understanding 😄 |
…m the stdin stream (fixes #90)