-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pnpm #2
Added pnpm #2
Conversation
index.js
Outdated
runBenchmark('npm5', ['install'], 'shrinkpack-compressed'); | ||
runBenchmark('pnpm', ['install'], 'pnpm'); | ||
runBenchmark('pnpm', ['install'], 'pnpm-cached'); | ||
runBenchmark('pnpm', ['install'], 'pnpm-offline'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you pass the --offline
param to pnpm? It won't work in offline mode w/o it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally had it and removed it, because I thought the npmrc file was enough to force it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npmrc should be fine as well. I don't see an npmrc file with offline = true
in this PR though.
oh, and pnpm should be added to the top of README, where all the different package managers are listed |
@JamieMason or @siddharthkp do either of you want to run this and update the results, since npm5+shrinkwrap won't run for me? |
Sure @Akkuma, would you mind updating your branch with the latest from master please? Then I'll be happy to do the rest when I'm next free on Thursday eve. Thanks a lot for this. |
I've run out of time for today but fyi your work is merged into https://github.com/JamieMason/npm-cache-benchmark/commits/Akkuma-master and will be released once some other bits have been finished up, thanks. |
I'll close this PR as it'll be going into https://github.com/JamieMason/npm-cache-benchmark, please add any comments at JamieMason#4 – thanks. |
Locally I could not get npm5 + shrinkwrap working, but I added pnpm @zkochan would be great to do a quick once over to ensure I've implemented everything correctly.
My own results look like: