react-docgen no longer has react-docgen/dist/babylon

[reintroducing]

This is causing an error in version 8.0.5+ of react-styleguidist now when using this plugin.

Cannot find module 'react-docgen/dist/babylon'
npx styleguidist server --open exited with code 1

[siddharthkp]

Great catch! Do you know the replacement for it?

[danez]

The replacement is: react-docgen/dist/babelParser.

I guess doing this should make it possible for old and new versions to work:

let babylon
try {
    babylon = require(`react-docgen/dist/babelParser`).default
} catch (e) {
   babylon = require(`react-docgen/dist/babylon`).default
}

[reintroducing]

Thanks @danez for following up on this. @siddharthkp any chance we can get an updated version with the changes so we can upgrade react-styleguidist without issue?

[Slowl]

Thanks @danez ! It fixed my issue but now, docgen return an empty object for every components that require an external variable to define some proptypes
Any idea on how to fix that ?

[reintroducing]

Any movement on this one gentlemen?

[siddharthkp]

Well, I'm not actively maintaining this package (clearly? 😅)

Added @danez as a collaborator to both this repo and package on npm to take this forward

@danez You cool with that?

[Slowl]

@reintroducing I personally downgraded react-docgen to a stable version until a fix is found for react-docgen >v3

[danez]

@danez You cool with that?

Okay, thanks.

[danez]

Okay fixed in 1.0.1.

[reintroducing]

Hmm, I just updated and while it does compile, there are now errors for the components that had the setup like I mentioned here: #1
Warning: Cannot parse src/TextInput/TextInput.jsx: TypeError: options.parser.parse is not a function

I can actually fix the errors by destructuring the propTypes like so:

static propTypes = {
    ...TextInputPropTypes,
};

However that doesn't actually fix the propTypes listed in the style guide.

Prior to update: https://www.dropbox.com/s/yhh131i6fvxeqj8/Screenshot%202018-12-13%2007.59.33.png?dl=0

After update: https://www.dropbox.com/s/znok10q5ruwvslw/Screenshot%202018-12-13%2007.59.55.png?dl=0

Post update, only the defaultProps show. Any idea whats going on?

[danez]

Can you try again with 1.0.2? It should work now. Sorry for the mistake.

[reintroducing]

@danez Please don't be sorry, you're helping out on an OSS project, I really appreciate you even taking time to do this.

As for the update, it fixed most of the components that were erroring last time except one. The new error I now see in that component is Warning: Cannot parse src/TextInput/TextInput.jsx: TypeError: Cannot read property 'loc' of null.

That component's propTypes are simply static propTypes = TextInputPropTypes; and it does work with v1.0.0 and react-styleguidist v8.0.4. Upgrading both to v1.0.2 and v8.0.5+ breaks it with the above error.

[coreybruyere]

@reintroducing did you ever get this resolved? Keep running into issues you've ran into in some of these GH Issue threads. I'm trying to import and destructure propTypes into my component but I'm having trouble documenting those propTypes in Styleguidist.

Example of what I'm trying to do:
https://spectrum.chat/styled-components/general/how-to-import-external-dep-proptypes-to-display-in-styleguidist~6258f2a2-c31c-4e56-b1ba-45550cbcfa55

[reintroducing]

@coreybruyere unfortunately no, and i've just stayed on v8.0.4 of react-styleguidist as a result to make sure i'm not getting the errors.