Fix reading mode when binary mapping is given #69

ramindu90 · 2019-10-03T09:09:15Z

Purpose

Enable to to read file as a whole when binary mapping/ file is given
Disable reading file in lines when binary mapping is given

Add file mode property when creating VFSClientConnector

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

ramindu90 added 5 commits October 3, 2019 14:22

Fix reading mode when binary mapping is given

bfa33f5

Merge upstream master

a9df834

Bump transport-file version

c0da08b

Fix constant import

67aca33

Add check for source type when validating file mode and mapping type

a77913d

ramindu90 force-pushed the master branch from 0ff33ba to a77913d Compare October 3, 2019 11:15

ramindu90 requested a review from mohanvive October 3, 2019 11:16

ramindu90 force-pushed the master branch from 16262a7 to 932fd48 Compare October 3, 2019 11:29

Use inMemory Source for the test cases

932fd48

sajithshn approved these changes Oct 3, 2019

View reviewed changes

sajithshn merged commit efb327e into siddhi-io:master Oct 3, 2019