Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise Siddhi MongoDB store query execution #56

Merged
merged 43 commits into from
Nov 24, 2019

Conversation

PrabodDunuwila
Copy link
Contributor

@PrabodDunuwila PrabodDunuwila commented Nov 20, 2019

Purpose

  • Optimize MongoDB store to execute select clause in DB by pushing the querying to DB level rather than fetch the records to Siddhi level and executing queries at Siddhi level.

Goals

  • Selection of stream, store and constants and supports logical operators, inline math operators, comparison operators and 'is null'.
  • Group by with functions min, max, avg, sum and count.
  • Having, order by, limit and offset.

Approach

  • Implement compileSelection method and query method in MongoDBEventTable. And used a visitor for selection named 'MongoSelectExpressionVisitor'.

Release note

Optimise Siddhi MongoDB store query execution

Documentation

N/A as this is optimisation

Automation tests

  • Unit tests - 91%
  • Integration tests - N/A

Security checks

Test environment

JDK 1.8, MongoDB 3.6, 4.2

@niveathika
Copy link
Member

@PrabodDunuwila It seems your commit messages are clear enough, but better follow standards when coming up with commit messages, as I see some common flows as not using Imperative mood.
Follow them from here on out, https://chris.beams.io/posts/git-commit/

@niveathika
Copy link
Member

Let's add more information to the PR since it is referred from the release note and the above info is not enough. Try not to remove content heading in PR template when it is major improvement/new feature

@niveathika niveathika changed the title Improvements to MongoDB store to execute queries at DB level [WIP] Optimise MongoDB store to execute select clause in the DB Nov 20, 2019
@niveathika niveathika changed the title [WIP] Optimise MongoDB store to execute select clause in the DB [WIP] Optimise Siddhi MongoDB store query execution Nov 20, 2019
@niveathika niveathika changed the title [WIP] Optimise Siddhi MongoDB store query execution Optimise Siddhi MongoDB store query execution Nov 24, 2019
@niveathika niveathika merged commit 47bf123 into siddhi-io:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants