Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: also check style & types in CI pipeline, fix template-formatting for everything that came malformatted #10

Merged

Conversation

BracketJohn
Copy link
Contributor

@BracketJohn BracketJohn commented Jan 10, 2023

This PR:

  • adds CI steps to:
    • lint the --ci output test project
    • typecheck the --ci output test project
    • run all of the --ci checks for the package managers: pnpm, npm
  • fixes templates that were broken based on above checks

@BracketJohn
Copy link
Contributor Author

-> fails if npm install is not run

@BracketJohn BracketJohn changed the title feat: add step that automatically lint & fix all files to avoid problems from raw template strings feat: also check style & types in CI pipeline, fix template-formatting for everything that came malformatted Jan 11, 2023
@BracketJohn
Copy link
Contributor Author

-> fails if npm install is not run

resolved by not adding automatic linting and instead fixing the source of the issue: bad templates. The CI pipeline will catch these in the future now

@BracketJohn BracketJohn merged commit 24d3a43 into main Jan 11, 2023
@BracketJohn BracketJohn deleted the autofix_format_according_to_eslint_to_avoid_template_conflicts branch January 11, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant