Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new Landing Page design #16

Merged
merged 16 commits into from
Feb 9, 2023
Merged

Added new Landing Page design #16

merged 16 commits into from
Feb 9, 2023

Conversation

zoey-kaiser
Copy link
Member

Screenshot 2023-02-09 at 09 39 41

BracketJohn
BracketJohn reviewed Feb 9, 2023
View reviewed changes
src/steps/2.addModules/moduleConfigs.ts Outdated Show resolved Hide resolved
src/steps/2.addModules/moduleConfigs.ts Outdated Show resolved Hide resolved
src/steps/2.addModules/index.ts Outdated Show resolved Hide resolved
src/steps/2.addModules/index.ts Outdated Show resolved Hide resolved
BracketJohn
BracketJohn requested changes Feb 9, 2023
View reviewed changes
src/steps/2.addModules/generateIndexVue.ts Outdated Show resolved Hide resolved
src/steps/2.addModules/generateIndexVue.ts Show resolved Hide resolved
src/steps/2.addModules/moduleConfigs.ts Outdated Show resolved Hide resolved
src/steps/2.addModules/moduleConfigs.ts Outdated Show resolved Hide resolved
@BracketJohn
Copy link
Contributor

could you remove the publish step from the pipeline? It's broken and unused and makes it look like everything is failing

BracketJohn
BracketJohn requested changes Feb 9, 2023
View reviewed changes
.github/workflows/cd.yaml Outdated Show resolved Hide resolved
@BracketJohn
Copy link
Contributor

BracketJohn commented Feb 9, 2023 •
edited by zoey-kaiser
Loading

image

  • the bottom 3 tiles are a bit too colorless / seethrough
  • let's make the nuxt-auth title Authentication and then mention nuxt-auth in the text below
  • can we add an indication that the "read documentation" links are clickable
  • can we change the cursor type for the cards? right now it switches to the "text select" cursor, which is not super nice. Regular pointer (besides over the clickable links at the bottom) would be better

@zoey-kaiser
Copy link
Member Author

Screenshot 2023-02-09 at 11 43 15

BracketJohn
BracketJohn reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@BracketJohn BracketJohn left a comment •
edited by zoey-kaiser
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's remove the other example pages now that we move to this index.vue only approach, right?
    image

  • please handle the case where no modules are added gracefully (note eg the trailing colon):

image

Other than that I texted it through and I like it (:

src/steps/2.addModules/generateIndexVue.ts Outdated Show resolved Hide resolved
@zoey-kaiser
Copy link
Member Author

  • Let's remove the other example pages now that we move to this index.vue only approach, right?

I would personally keep them until I get to adding the examples to the index file. This way it is also easier for me to migrate once I get to this step

@BracketJohn
Copy link
Contributor

Okay, lets keep em in (:

@BracketJohn BracketJohn merged commit 33815c5 into main Feb 9, 2023
@BracketJohn BracketJohn deleted the new-landing-design branch February 9, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BracketJohn BracketJohn BracketJohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zoey-kaiser @BracketJohn