Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing middleware option for guestmode #697

Merged
merged 2 commits into from Mar 3, 2024

Conversation

anischihi
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I tried the guest middleware, it did not work (n redirect, no unauthenticatedOnly behaviour). Added the missing snippet, everything works like a charm. I think has been missed in the docs. You can try for yourself.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

I tried the guest middleware, it did not work (not redirect, no unauthenticatedOnly nehaviour). Added the missing snippet, everything works like a charm.
I think has been missed in the docs. You can try for yourself
@MuhammadM1998
Copy link
Contributor

I suggested this in an issue before but Zoey said this is expected when turning off the global middleware (You don't need to add this line if global middleware is enabled). Maybe a hint that this line is needed only when disabling global middleware would be best?

@zoey-kaiser
Copy link
Member

I suggested this in an issue before but Zoey said this is expected when turning off the global middleware (You don't need to add this line if global middleware is enabled). Maybe a hint that this line is needed only when disabling global middleware would be best?

Works for me! Adding the value will not hurt in any case, but as you pointed out, could help reduce confusion. Thanks for making the adjustment ❀️

Add comment to addition

Co-authored-by: Zoey <zoeykaiser8@gmail.com>
@zoey-kaiser zoey-kaiser changed the title fix(5.guest-mode.md): Add missing property to documentation docs: Add missing middleware option for guestmode Mar 3, 2024
@zoey-kaiser zoey-kaiser merged commit 7865ba3 into sidebase:main Mar 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants