Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#635): allow changing refresh request body via json pointer #727

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

phoenix-ru
Copy link
Collaborator

πŸ”— Linked issue

Closes #635

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows setting custom refresh request body to allow usages with external backends

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@MisterNox
Copy link

I came across the same issue today. We should also do it for the signOut method as libraries like django simple jwt require to have the refresh token in the body for their standard blacklist class. This means rawRefreshToken.value = null should be moved after the fetch. And res = await _fetch(nuxt, path, { method, headers }) needs to be adjusted like you did in the refresh method to res = await _fetch(nuxt, path, { method, headers, body: objectFromJsonPointer(refreshRequestTokenPointer, refreshToken.value) }). What do you think?

@zoey-kaiser zoey-kaiser merged commit 5183748 into main Apr 5, 2024
4 checks passed
@zoey-kaiser zoey-kaiser deleted the feature/635-custom-refresh-request-token-pointer branch April 5, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom refresh token name.
3 participants