Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

Added demo docs and sync workflow #39

Merged
merged 10 commits into from
Nov 30, 2022
Merged

Added demo docs and sync workflow #39

merged 10 commits into from
Nov 30, 2022

Conversation

zoey-kaiser
Copy link
Member

WIP

@zoey-kaiser
Copy link
Member Author

zoey-kaiser commented Nov 25, 2022

This PR currently runs a Github Action called "Sync Docs". What it does it open a PR on https://github.com/sidebase/docs.

It adds:

Files from .docs/content to content/nuxt-session - For the READMEs
Files from .docs/public to public - For any Images used in the docs

Once you merge the new docs in the repestive module repo, you can merge the created PR, to pull the changes onto the Website. We can then add a Action there, to update the website automatically!

Checkout the PR, this PR created: sidebase/docs#2 - Changing anything to the docs in this PR will also update the files in the PR in the docs repo.

Currently todo:

  • Get a Personal Access Token for the sideborg account (currently we use my private one, which we do not want to do!)
  • Deploy sidebase/docs under the subdomain v2.sidebase.io or another test domain

@BracketJohn
Copy link
Contributor

Thanks!

  • Is there a remaining reason for putting the docs into a "secret" .docs folder?
  • How can we enable "auto-merge" so that the syncing does not need manual action?
  • Are you blocked here by me in any way atm?

@zoey-kaiser
Copy link
Member Author

Is there a remaining reason for putting the docs into a "secret" .docs folder?

I was doing it the way that the docus repo did it: https://github.com/nuxt-themes/docus/tree/dev/.docs
But in the end we can also make it just docs!

How can we enable "auto-merge" so that the syncing does not need manual action?

I was thinking about this. I assume we could enable auto-merge from GitHub. Meaning, if there are no conflicts and the CI passes, it would get merged. I can play with these settings and find a way to get it working!

Are you blocked here by me in any way atm?

I would not say so. I just wanted to ensure you had a look at my PoC. If you are happy with the implementation we can move forward to:

  • Getting PRs like this set up in every repo.
  • Writing the docs for every repo.
  • Deploying a beta on v1.sidebase.io

An issue I am still facing in this repo is this: nuxt-themes/docus#680. The docus team recommended we upgrade the module to Nuxt3 stable. I will add a new PR in nuxt-auth and see if that resolves it, as we already upgraded there!

@BracketJohn
Copy link
Contributor

But in the end we can also make it just docs!

yeah,. let's move to just docs

I was thinking about this. I assume we could enable auto-merge from GitHub. Meaning, if there are no conflicts and the CI passes, it would get merged. I can play with these settings and find a way to get it working!

this is essential, else the whole sync-workflow will not have solved the problem that contributions to docs in repo A need manual steps (that will be forgotten or too tedious for outside / inside collaborators) in order to go-live.

I would not say so. I just wanted to ensure you had a look at my PoC. If you are happy with the implementation we can move forward to:

let's adapt thjis a bit:

  1. get auto-sync without human inference to work (remember: this was a requirement I posed to accept this solution)
  2. get this pr merged
  3. see if the sync workflow works
  4. test out npm run build && npm run preview in the docs repo to see that everything works in theory
  5. then in parallel:
    • get @DeusAvalon to deploy it into the cluster with CD
    • do the docs PRs on other repos

@zoey-kaiser zoey-kaiser marked this pull request as ready for review November 30, 2022 16:38
Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a lot bigger than sidebase/nuxt-parse#3 - is this on purpose?

@@ -0,0 +1 @@
This is a test asset to move to the docs folder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to keep these in here to already have the public folder. I was scared that without it people would not know where to put their images for the docs.

@@ -0,0 +1,3 @@
# Create one with no scope selected on https://github.com/settings/tokens/new
# This token is used for fetching the repository releases.
GITHUB_TOKEN=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would delete this file anyway, as it was only included in the bootstrapped docus project.

@zoey-kaiser
Copy link
Member Author

This PR is a lot bigger than sidebase/nuxt-parse#3 - is this on purpose?

In the nuxt-parse PR the package.lock.json was missing. Therefore the big difference. As docus is currently not working anyway in these PRs and will need to be refactored, we could either delete the package-lock or ignore it.

@BracketJohn
Copy link
Contributor

Let's ignore and keep it for now, thanks. Please delete the env file so that we can contuinue

@zoey-kaiser
Copy link
Member Author

Let's ignore and keep it for now, thanks. Please delete the env file so that we can contuinue

Deleted!

@BracketJohn BracketJohn merged commit df5b985 into main Nov 30, 2022
@BracketJohn BracketJohn deleted the add-docs branch November 30, 2022 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants