Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when job key is a symbol and sidekiq runs twice #108

Merged
merged 1 commit into from
May 11, 2016
Merged

Fix bug when job key is a symbol and sidekiq runs twice #108

merged 1 commit into from
May 11, 2016

Conversation

matu1104
Copy link
Contributor

@matu1104 matu1104 commented May 4, 2016

This change is related to #102

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 95.694% when pulling a8ba612 on matu1104:master into 27c54fa on moove-it:master.

let(:job_id) { :super_job }

context 'when schedule is set twice' do
it 'sets the schedule on redis' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not fail when running the specs with seed = 9838. Please flush Redis on a before hook (see spec/sidekiq/scheduler_spec.rb)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment. I just pushed a new change.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 95.839% when pulling 8830829 on matu1104:master into 27c54fa on moove-it:master.

@snmgian snmgian merged commit 8043b72 into sidekiq-scheduler:master May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants