Update README to reflect reading Rails timezone #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfrenette
approved these changes
Aug 7, 2020
It appears that rufus-scheduler version 3.3.3 [uses the Rails timezone](jmettraux/rufus-scheduler@dc9e9df) if Rails is detected. [This commit](sidekiq-scheduler@4b7eb81) bumps the version of rufus-scheduler, allowing it to upgrade to 3.3.x, which includes the change. This change modifies the README regarding cron syntax, to indicate that the current version of sidekiq_scheduler does use the Rails timezone when parsing cron statements.
taylorkearns
force-pushed
the
fix/update-timezone-readme
branch
from
65756c3
to
5703692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that rufus-scheduler version 3.3.3 uses the Rails timezone if Rails is detected. This commit bumps the version of rufus-scheduler, allowing it to upgrade to 3.x, which includes the change.
This change modifies the README regarding cron syntax, to indicate that the current version of sidekiq_scheduler does use the Rails timezone when parsing cron statements.
Fixes #309