capistrano task #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tried this, and I seemed to loose the currently running job, any thoughts? |
|
I think it might happen if you added require 'sidekiq/capistrano' in your config/deploy.rb, you need to replace it with require 'sidekiq-scheduler/capistrano' |
|
I didn't require any, as I wanted to stay with the official fork, rather than changing to yours. So i literally just copied the relevant deploy code / hooks into my deploy.rb. Any other thoughts? |
|
Nope for now :-( |
|
Any updates regarding loosing jobs? Since I don't use capistrano I can't verify and I would like to avoid merging this if it isn't working correctly. |
|
All sorted now I believe, I'll let you know if I have any other problems. Go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I just added capistrano support for sidekiq-scheduler and wiki file for it. Waiting for acceptance.
Have a nice day,
Mustafa