Add JID for inline testing, fixes #1454

sidekiq · Jan 30, 2014 · b0107b5 · b0107b5
1 parent 3a6cadc
commit b0107b5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/Changes.md b/Changes.md
@@ -1,3 +1,11 @@
+HEAD
+-----------
+
+- Fix JID support in inline testing, #1454
+- Polish worker arguments display in UI, #1453
+- Marshal arguments fully to avoid worker mutation, #1452
+
+
 2.17.3
 -----------
 

diff --git a/lib/sidekiq/testing.rb b/lib/sidekiq/testing.rb
@@ -1,3 +1,5 @@
+require 'securerandom'
+
 module Sidekiq
 
   class Testing
@@ -64,8 +66,11 @@ def raw_push(payloads)
         true
       elsif Sidekiq::Testing.inline?
         payloads.each do |item|
+          jid = item['jid'] || SecureRandom.hex(12)
           marshalled = Sidekiq.load_json(Sidekiq.dump_json(item))
-          marshalled['class'].constantize.new.perform(*marshalled['args'])
+          worker = marshalled['class'].constantize.new
+          worker.jid = jid
+          worker.perform(*marshalled['args'])
         end
         true
       else

diff --git a/test/test_testing_inline.rb b/test/test_testing_inline.rb
@@ -17,6 +17,7 @@ class ParameterIsNotString < RuntimeError; end
     class InlineWorker
       include Sidekiq::Worker
       def perform(pass)
+        raise ArgumentError, "no jid" unless jid
         raise InlineError unless pass
       end
     end