Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Rails 5's new Interlock #2450

Closed
mperham opened this issue Jul 22, 2015 · 5 comments
Closed

Integrate Rails 5's new Interlock #2450

mperham opened this issue Jul 22, 2015 · 5 comments

Comments

@mperham
Copy link
Collaborator

mperham commented Jul 22, 2015

Rails 5 now supports thread-safe code reloading!!!!!! 馃帀 馃嵃

Integrate the new Interlock into the Processor so we can reload Workers before executing them. This is Rails 5+ in development mode only so we'll need to keep the current code flow for Rails 3 and 4 and other environments.
@ryansch
Copy link
Contributor

ryansch commented Jul 22, 2015

Wow! 馃帀 馃巿

mperham added a commit that referenced this issue Jul 22, 2015
@mperham
WIP Integrate support for Rails' Interlock, #2450
be2d129
@davydovanton
Copy link
Contributor

looks amazing! 馃帀 馃専

@hbin
Copy link

hbin commented Aug 15, 2015

馃憦 馃憦 馃憦

@mperham mperham mentioned this issue Feb 12, 2016
Closed
@mperham mperham closed this as completed Sep 6, 2016
@mperham
Copy link
Collaborator Author

mperham commented Sep 6, 2016

Coming in 4.2.0.

@lastobelus
Copy link

This is so great. Thanks.

Something is borken in rails though...sidekiq jobs reload reliably now, but controllers & helpers not so much.

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this issue Nov 21, 2018
@stanhu
Fix error when reloading code in Sidekiq
41987bc 
Now that Rails 5 supports thread-safe code reload
(sidekiq/sidekiq#2450), we encounter errors
when the Rails app code changes in development. We need to add `::` in
one middleware so that Object.const_missing will be invoked instead of
Metrics.const_missing.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54320
tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this issue Nov 21, 2018
@stanhu
Fix error when reloading code in Sidekiq during development
eb51aa1 
Now that Rails 5 supports thread-safe code reload
(sidekiq/sidekiq#2450), we encounter errors
when the Rails app code changes in development. We need to add `::` in
one middleware so that Object.const_missing will be invoked instead of
Metrics.const_missing.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54320
@lefty313 lefty313 mentioned this issue Feb 4, 2019
Open
@ibrahima ibrahima mentioned this issue May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mperham @lastobelus @ryansch @davydovanton @hbin