APP_ENV overrides RAILS_ENV

[prem-prakash]

Ruby version: 2.7.0
Sidekiq / Pro / Enterprise version(s): 6.0.5

https://github.com/mperham/sidekiq/blob/22e812d3f1ae9a3e5faa79637a61705186d6961e/lib/sidekiq/cli.rb#L244

Although APP_ENV will possibly become a default soon, a user may inadvertently or unintentionally overwrite RAILS_ENV by setting APP_ENV.

[mperham]

Correct. By design.

[prem-prakash]

If Rails does not use APP_ENV, it is not correct, it is unexpected behavior and it is not documented. It is at least an incompatibility with the most current Rails.

[mperham]

Then let’s get it documented. 💪🏻

…

On May 7, 2020, at 14:41, Prakash ***@***.***> wrote:  If Rails does not use APP_ENV, it is not correct, it is unexpected behavior and it is not documented. It is at least an incompatibility with the most current Rails. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

[mperham]

https://github.com/mperham/sidekiq/wiki/Advanced-Options#environment

[prem-prakash]

Thank you 🙏

[TheKidCoder]

@mperham This is causing issues in our app and will require a change to a number of areas - is there a reason we can't just simplify this to a SIDEKIQ_ENV?

[mperham]

@TheKidCoder Have you tried sidekiq -e? 😂

[stevehanson]

This is also causing an issue for me as I use APP_ENV for other purposes. A simple solution would be to also support SIDEKIQ_ENV and have it take precedence over any other ENV variables. Happy to make a PR if we're open to this.

[mperham]

@stevehanson Is there some reason you can't use -e?

[stevehanson]

We have a script to launch sidekiq that is used in different environments and doesn't have access to the dotenv config where RAILS_ENV is set. I just updated our app to use something other than APP_ENV since that seemed to be the simplest recourse in my case.

More generally, it seems like if Sidekiq uses a generic name like APP_ENV, it should provide a mechanism to get around it without having to modify build scripts. Another gem or app code could just as easily also use APP_ENV but in a different way.

[mperham]

I've opened an issue with puma about the variable. puma/puma#2692