Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support APP_ENV? #2692

Closed
mperham opened this issue Sep 7, 2021 · 3 comments
Closed

Support APP_ENV? #2692

mperham opened this issue Sep 7, 2021 · 3 comments
Labels
feature

Comments

@mperham
Copy link

mperham commented Sep 7, 2021

Several years ago, I added support in Sidekiq for APP_ENV as a generic replacement to RAILS_ENV and RACK_ENV. The idea being that RAILS_ENV doesn't make sense if you are using Sinatra, RACK_ENV doesn't make sense if you are using Sidekiq, etc. What we are really trying to express here is the environment specific to the running application code. This term makes sense no matter what specific framework or infrastructure the user is running.

WDYT?
@mperham mperham mentioned this issue Sep 7, 2021
Closed
@dentarg
Copy link
Member

dentarg commented Sep 7, 2021

I'm 👍 on APP_ENV. Supported in Sinatra since v2.0.0. More related previous discussion: sinatra/sinatra#984

@nateberkopec
Copy link
Member

What precedence/order would we go with?

@mperham
Copy link
Author

mperham commented Sep 7, 2021

Here’s Sidekiq’s impl: https://github.com/mperham/sidekiq/blob/0bdec6f144de449c8cc4c945acd41d1248a2619d/lib/sidekiq/cli.rb#L198

jacobherrington added a commit to jacobherrington/puma that referenced this issue Sep 17, 2021
@jacobherrington
Add support for APP_ENV environment variable
e721958 
Using APP_ENV to set the environment is supported by Sinatra and
Sidekiq, so it makes sense to support the same behavior in Puma.

Like Sidekiq, APP_ENV will take precendence over RACK_ENV and RAILS_ENV.
APP_ENV defers to any argument passed via the --environment flag.

Solves: puma#2692
jacobherrington added a commit to jacobherrington/puma that referenced this issue Sep 17, 2021
@jacobherrington
Add support for APP_ENV environment variable
9e4601e 
Using APP_ENV to set the environment is supported by Sinatra and
Sidekiq, so it makes sense to support the same behavior in Puma.

Like Sidekiq, APP_ENV will take precendence over RACK_ENV and RAILS_ENV.
APP_ENV defers to any argument passed via the --environment flag.

Closes puma#2692
jacobherrington added a commit to jacobherrington/puma that referenced this issue Sep 17, 2021
@jacobherrington
Add support for APP_ENV environment variable
ee2a68e 
Using APP_ENV to set the environment is supported by Sinatra and
Sidekiq, so it makes sense to support the same behavior in Puma.

Like Sidekiq, APP_ENV will take precedence over RACK_ENV and RAILS_ENV.
APP_ENV defers to any argument passed via the --environment flag.

Closes puma#2692
JuanitoFatas pushed a commit to JuanitoFatas/puma that referenced this issue Sep 9, 2022
@jacobherrington @JuanitoFatas
Add support for APP_ENV environment variable
5553812 
Using APP_ENV to set the environment is supported by Sinatra and
Sidekiq, so it makes sense to support the same behavior in Puma.

Like Sidekiq, APP_ENV will take precedence over RACK_ENV and RAILS_ENV.
APP_ENV defers to any argument passed via the --environment flag.

Closes puma#2692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mperham @dentarg @nateberkopec