-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of at
in push_bulk
#4601
Comments
1 would be my choice. |
BuonOmo
added a commit
to BuonOmo/sidekiq
that referenced
this issue
Jun 18, 2020
In `Sidekiq::Client.bulk_push`, now 'at' size must be the same size as 'args' (or just be a single numeric). Fixes sidekiq#4601
Here it is then 🙂 |
mperham
pushed a commit
that referenced
this issue
Jun 18, 2020
In `Sidekiq::Client.bulk_push`, now 'at' size must be the same size as 'args' (or just be a single numeric). Fixes #4601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ruby version: X
Sidekiq version: 6.X
The current (
>= 6
) version ofSidekiq::Client.push_bulk
accepts anat
that could be an array of numeric timestamps. However, if the size of that array doesn't match the number of jobs, this will throw a redis error:I'd be glad to fix this one, but there are many way to do so... Here are the solutions I had in mind:
ArgumentError
if size mismatchat
item as default when at is smaller:The text was updated successfully, but these errors were encountered: