You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ruby version: 3.3.0
Sidekiq / Pro / Enterprise version(s): master
Ruby 3.3 emits a warning when base64 is required without being specified in the gemspec. Ruby 3.4 will error.
There are a few places in sidekiq where base64 is being made use of. These should either be refactored to not use the gem, or it should be added to the gemspec.
Ruby version: 3.3.0
Sidekiq / Pro / Enterprise version(s): master
Ruby 3.3 emits a warning when base64 is required without being specified in the gemspec. Ruby 3.4 will error.
There are a few places in sidekiq where base64 is being made use of. These should either be refactored to not use the gem, or it should be added to the gemspec.
You can observe this warning in CI: https://github.com/sidekiq/sidekiq/actions/runs/7358335463/job/20031428359
Ignore the other warnings, they originate from other gems. drb is from rails I believe.
I've gone through a few gems I use and made PRs to replace this gem with pack/unpack, since that is basically everything that it's doing. However, here the url safe variants are used which does a bit more than just calling a differently named method and inlining that here doesn't feel that great.
https://github.com/ruby/base64/blob/9669a7d3b0e3b9a739969404daf58f912c58c6b3/lib/base64.rb#L328-L333
https://github.com/ruby/base64/blob/9669a7d3b0e3b9a739969404daf58f912c58c6b3/lib/base64.rb#L351-L362
base64
gem from runtime dependency rubocop/rubocop#12313The text was updated successfully, but these errors were encountered: