Added helper which provide ability to add your html to <head> tag #2270

davydovanton · 2015-03-27T14:12:51Z

Why this needed?

These changes will allow easily define custom tags for page <head> in any sidekiq plugins.

Use case

# in view
<% add_to_head do %>
  <link rel="stylesheet" href="/plugin.css" />
<% end %>

# in web extention
app.get '/plugin.css' do
  custom_css ['/sidekiq/plugin.css']

  # you page code here
end

mperham · 2015-03-27T16:17:11Z

I'd prefer to see a block helper for rendering the UI so the plugin author can inject any sort of head content:

<% add_to_head do %>
  <link rel="stylesheet" .../>
<% end %>
<h1>History</h1>
...

davydovanton · 2015-03-27T16:41:47Z

wow! I like it, thanks for great idea 👍

davydovanton · 2015-03-27T23:42:32Z

@mperham I changed helper. But rubinius test is failed in this and this tests. It's normal? %)

mperham · 2015-03-27T23:53:59Z

Fantastic. 🤘

mperham · 2015-03-27T23:54:41Z

Can you make it support multiple blocks?

davydovanton · 2015-03-28T00:06:19Z

@mperham I'm sorry, but i don't understand you correctly 😓
What do you mean by multiple blocks? Something like this:

# in partial #1
<% add_to_head do %>
  <link rel="stylesheet" href="css1.css"/>
<% end %>

# in partial #2
<% add_to_head do %>
  <link rel="stylesheet" href="css2.css"/>
<% end %>

# in partial #3
<% add_to_head do %>
  <link rel="stylesheet" href="css3.css"/>
<% end %>

# in layout partial
<%= display_custom_head %>
# => <link rel="stylesheet" href="css1.css"/>
     <link rel="stylesheet" href="css2.css"/>
     <link rel="stylesheet" href="css3.css"/>

?

mperham · 2015-03-28T00:16:29Z

Exactly.

On Mar 27, 2015, at 17:06, Anton Davydov notifications@github.com wrote:

@mperham I'm sorry, but i don't understand you correctly
What do you mean by multiple blocks? Something like this:

in partial #1

<% add_to_head do %>
<% end %>
in partial #2

<% add_to_head do %>
<% end %>
in partial #3

<% add_to_head do %>
<% end %>
in layout partial

<%= display_custom_head %>

=>
 <link rel="stylesheet" href="css2.css"/>
 <link rel="stylesheet" href="css3.css"/>
?

—
Reply to this email directly or view it on GitHub.

davydovanton · 2015-03-28T12:59:07Z

@mperham I have a little problem with procs in erb, that why I'll hold PR a little 😟

davydovanton · 2015-03-30T00:42:35Z

@mperham I solved my problem with erb 🎉 and also I wrote a post about solving this problem 😄

mperham · 2015-03-30T15:35:46Z

Beautiful, really nice work.

Added helper which provide ability to add your html to <head> tag

davydovanton · 2015-03-30T15:59:22Z

Thanks! 🎆

davydovanton force-pushed the overall-css branch 3 times, most recently from 3756789 to 8488dee Compare March 27, 2015 23:31

davydovanton changed the title ~~Added web helper which provide ability to add your own css urls to page~~ Added helper which provide ability to add your html to <head> tag Mar 27, 2015

Added helper which provide ability to add your html to <head> tag

fc144dd

davydovanton force-pushed the overall-css branch from 8488dee to fc144dd Compare March 30, 2015 00:39

mperham added a commit that referenced this pull request Mar 30, 2015

Merge pull request #2270 from davydovanton/overall-css

71e5237

Added helper which provide ability to add your html to <head> tag

mperham merged commit 71e5237 into sidekiq:master Mar 30, 2015

davydovanton deleted the overall-css branch March 30, 2015 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added helper which provide ability to add your html to <head> tag #2270

Added helper which provide ability to add your html to <head> tag #2270

davydovanton commented Mar 27, 2015

mperham commented Mar 27, 2015

davydovanton commented Mar 27, 2015

davydovanton commented Mar 27, 2015

mperham commented Mar 27, 2015

mperham commented Mar 27, 2015

davydovanton commented Mar 28, 2015

mperham commented Mar 28, 2015

in partial #1

in partial #2

in partial #3

in layout partial

=>

davydovanton commented Mar 28, 2015

davydovanton commented Mar 30, 2015

mperham commented Mar 30, 2015

davydovanton commented Mar 30, 2015

Added helper which provide ability to add your html to <head> tag #2270

Added helper which provide ability to add your html to <head> tag #2270

Conversation

davydovanton commented Mar 27, 2015

Why this needed?

Use case

mperham commented Mar 27, 2015

davydovanton commented Mar 27, 2015

davydovanton commented Mar 27, 2015

mperham commented Mar 27, 2015

mperham commented Mar 27, 2015

davydovanton commented Mar 28, 2015

mperham commented Mar 28, 2015

in partial #1

in partial #2

in partial #3

in layout partial

=>

davydovanton commented Mar 28, 2015

davydovanton commented Mar 30, 2015

mperham commented Mar 30, 2015

davydovanton commented Mar 30, 2015