Fix Uncaught exception: can't dump IO
#5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error occurs when the underlying Redis client is configured with a
logger, due to the limitations of `Marshal` when dealing with `IO`
objects. This change excludes the `:logger` option in a similar fashion
to the way `:ssl_params` is currently excluded.
This error can be reproduced with the following:
Sidekiq.configure_client do |config|
config.redis = { logger: Logger.new(STDOUT) }
end
The complete exception message and stacktrace is as follows:
Uncaught exception: can't dump IO
/usr/local/bundle/gems/sidekiq-6.2.2/lib/sidekiq/redis_connection.rb:103:in `dump'
/usr/local/bundle/gems/sidekiq-6.2.2/lib/sidekiq/redis_connection.rb:103:in `log_info'
/usr/local/bundle/gems/sidekiq-6.2.2/lib/sidekiq/redis_connection.rb:32:in `create'
/usr/local/bundle/gems/sidekiq-6.2.2/lib/sidekiq.rb:137:in `redis='
|
Thanks for the fast merge! ❤️ |
|
Don't thank me until CI passes! 😂 Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error occurs when the underlying Redis client is configured with a logger, due to the limitations of
Marshalwhen dealing withIOobjects. This change excludes the:loggeroption in a similar fashion to the way:ssl_paramsis currently excluded.This error can be reproduced with the following:
The complete exception message and stacktrace is as follows:
Note: I recognize this isn't a common need but it's useful for enabling some additional debug logging from the Redis driver.