Prepare for upcoming Sidekiq::Config redesign #5340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the server internals to use a config object rather than refering directly to the Sidekiq module.
|
For 6.x, Sidekiq::Components will be passed the Sidekiq module itself as a parameter. This will become a |
|
Let’s discuss deeper design questions Monday.
…On Sun, May 29, 2022 at 16:29 Sam ***@***.***> wrote:
Whats your motivation behind using a config object over a sidekiq module?
—
Reply to this email directly, view it on GitHub
<#5340 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAWX4UPSJOKWY3CIOMDEDVMP4VPANCNFSM5WW3ZF2Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Sorry, forgot tomorrow is a holiday. Tuesday! |
|
No problem! See ya tomorrow!
…On Sun, May 29, 2022 at 21:27 Mike Perham ***@***.***> wrote:
Sorry, forgot tomorrow is a holiday. Tuesday!
—
Reply to this email directly, view it on GitHub
<#5340 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFL7TVQ2SAPQIZO5VVDXNLVMQ7SBANCNFSM5WW3ZF2Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I'm interested in contributing to this implementation as well. |
|
@TonsOfFun I don't have a good process for collaborating on this. |
|
The removal of What is the recommended way to provide extra context to exceptions in Sidekiq 6.x? In Discourse we've been using this: |
|
@CvX Please do not litter closed issues with your own problems. Open your own issue. I would be happy to help. |
st0012
added a commit
to getsentry/sentry-ruby
that referenced
this pull request
Jun 18, 2022
Sidekiq starts to store/pass configurations differently, which doesn't affect the SDK itself. But we need to update the test setup accordingly. Related PR:sidekiq/sidekiq#5340
st0012
added a commit
to getsentry/sentry-ruby
that referenced
this pull request
Jun 18, 2022
Sidekiq starts to store/pass configurations differently, which doesn't affect the SDK itself. But we need to update the test setup accordingly. Related PR:sidekiq/sidekiq#5340
st0012
added a commit
to getsentry/sentry-ruby
that referenced
this pull request
Jun 18, 2022
Sidekiq starts to store/pass configurations differently, which doesn't affect the SDK itself. But we need to update the test setup accordingly. Related PR:sidekiq/sidekiq#5340
st0012
added a commit
to getsentry/sentry-ruby
that referenced
this pull request
Jun 18, 2022
Sidekiq starts to store/pass configurations differently, which doesn't affect the SDK itself. But we need to update the test setup accordingly. Related PR:sidekiq/sidekiq#5340
anero
added a commit
to controlshift/sidekiq-rate-limiter
that referenced
this pull request
Jul 28, 2022
anero
added a commit
to controlshift/sidekiq-rate-limiter
that referenced
this pull request
Jul 28, 2022
anero
added a commit
to controlshift/sidekiq-rate-limiter
that referenced
this pull request
Jul 28, 2022
vishalzambre
added a commit
to vishalzambre/sidekiq-cloudwatchmetrics
that referenced
this pull request
Jul 29, 2022
Removed util support sidekiq/sidekiq#5340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the server internals to use a config object rather than refering directly to the Sidekiq module.