-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal patches #10
Comments
I wrote that code. It works like this: This code adds some custom middlewares to the internal express object. This can't be done with the proxy configuration because some of them have to be loaded even before testem defaults. The proxy config loads them after, I opened testem/testem#341 in the past, but apparently a better solution was coming and that PR was never merged. The two most important middlewares are
The first one has to be injected before any other middleware and there's no way to do it right now. Back to the previous point, I need to create a custom version of testem.js because I need to inject extra JS code in every test page. This code injects tl;dr
|
Testem has now an official way to add custom middlewares, doesn't this solve both issues? testem/testem#410 |
No, is this solution was never implemented. Middlewares now go first. I still need to add something after this one. |
What kind of hooks would you need to stop patching testem internals like https://github.com/sideroad/testem-multi/blob/master/lib/coverage_middleware.js#L12?
This patch is broken since
0.6.24
and I can really ensure, that we don't refactor code between releases.The text was updated successfully, but these errors were encountered: