Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove named result parameters #13

Merged
merged 1 commit into from
May 26, 2021

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented May 25, 2021

They serve no purpose there and increase the likelihood of shadowing problems.

Signed-off-by: Alexey Palazhchenko alexey.palazhchenko@gmail.com

@AlekSi
Copy link
Contributor Author

AlekSi commented May 25, 2021

/approve

They serve no purpose there and increase the likelihood of shadowing problems.

Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Copy link
Contributor Author

AlekSi commented May 26, 2021

/lgtm

@talos-bot talos-bot merged commit 80df078 into siderolabs:master May 26, 2021
@AlekSi AlekSi deleted the no-named-results branch May 26, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants