fix: function NewKeyPair should create certificate with proper subject #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was that generated certificate takes `Subject` from the CSR, but generated CSR was missing Subject field, as options were not passed in. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
Unix4ever
previously approved these changes
Jan 25, 2021
smira
force-pushed
the
fix-csr-subject
branch
from
8e550e4
to
aa59338
Compare
smira
changed the title
Unix4ever
approved these changes
Jan 25, 2021
|
/approve |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that generated certificate takes
Subjectfrom the CSR, butgenerated CSR was missing Subject field, as options were not passed in.
Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com