-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ZFS toolings #197
Conversation
0ad5b41
to
f5c9196
Compare
+1, lack of ZFS tools on host is also blocking https://github.com/democratic-csi/democratic-csi's zfs-local modes from working. democratic-csi uses |
Not a lot of experience with talos but author democratic-csi and get questions about this a bit. For the startup procedure should any further tooling be included to support or work with native zfs encryption? |
340b754
to
40c0600
Compare
/ok-to-test |
9d95be6
to
6676d0a
Compare
6676d0a
to
d1c428d
Compare
- rshared | ||
- rbind | ||
- rw | ||
# ld-musl-x86_64.so.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my understanding, if the extension anyway execs in pid 1 mount namespace, why do we need all the mounts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh good point, I'll drop those and test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh it still needs those:
10.5.0.3: 2023/08/21 12:13:28 zpool-importer: reexec failed: gons/reexec: ReexecAction.Run: child failed with stderr message "err: exit status 1, /dev/zfs and /proc/self/mounts are required.\nTry running 'udevadm trigger' and 'mount -t proc proc /proc' as root.\n"
I think i starts from the parent and targets the mount of pid 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm... I'm not sure I understand this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay /dev
is not needed, the other mounts are shared libraries, from the looks of it it seems the shared libs are needed in the parent mount namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks for checking!
d1c428d
to
8650927
Compare
Add ZFS user tools to manage ZFS pools. Add zpool-importer service which automatically mount ZFS pools on startup. Signed-off-by: David Donchez <david.donchez@enix.fr> Signed-off-by: Noel Georgi <git@frezbo.dev>
8650927
to
d369468
Compare
/m |
This extensions was built and tested on Talos 1.5.0
We have sucessfully tested it on Kubernetes with OpenEBS
The zpool-import-wrapper service works well, and ZFS pools are automatically imported on startup
If you want to test it and create a ZFS pool, you can use a node-shell with the host filesystem mounted on /host,
Then within the node-shell :
You will be able to create a ZFS pool:
Let me know if you need further informations.
Thanks