feat: add ZFS toolings

[donch]

• Add ZFS tools.
• Add a service to automatically import ZFS pools on startup.

This extensions was built and tested on Talos 1.5.0
We have sucessfully tested it on Kubernetes with OpenEBS
The zpool-import-wrapper service works well, and ZFS pools are automatically imported on startup

If you want to test it and create a ZFS pool, you can use a node-shell with the host filesystem mounted on /host,
Then within the node-shell :

mount -o bind /host/dev /dev
mount -o bind /host/usr/local/sbin /usr/local/sbin

You will be able to create a ZFS pool:

zpool create zfs-pool /dev/sdX

Let me know if you need further informations.
Thanks

[JJGadgets]

+1, lack of ZFS tools on host is also blocking https://github.com/democratic-csi/democratic-csi's zfs-local modes from working.

democratic-csi uses chroot for the ZFS tools expecting them to be available on the host, to offload the burden of maintaining tools' version sync with the kernel module to the host who should already manage the kernel module versioning.

[travisghansen]

Not a lot of experience with talos but author democratic-csi and get questions about this a bit. For the startup procedure should any further tooling be included to support or work with native zfs encryption?

[frezbo]

/ok-to-test

[smira]

for my understanding, if the extension anyway execs in pid 1 mount namespace, why do we need all the mounts?

[frezbo]

ahh good point, I'll drop those and test

[frezbo]

ahh it still needs those:

10.5.0.3: 2023/08/21 12:13:28 zpool-importer: reexec failed: gons/reexec: ReexecAction.Run: child failed with stderr message "err: exit status 1, /dev/zfs and /proc/self/mounts are required.\nTry running 'udevadm trigger' and 'mount -t proc proc /proc' as root.\n"

I think i starts from the parent and targets the mount of pid 1

[smira]

hmmm... I'm not sure I understand this...

[frezbo]

okay /dev is not needed, the other mounts are shared libraries, from the looks of it it seems the shared libs are needed in the parent mount namespace

[smira]

got it, thanks for checking!

[frezbo]

/m