fix: decode escape sequences while reading from kmsg #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
fix/decode-reader
branch
from
8f39f7c
to
d4ee764
Compare
frezbo
approved these changes
Jan 11, 2024
smira
force-pushed
the
fix/decode-reader
branch
from
d4ee764
to
6c7277c
Compare
The `/dev/kmsg` escapes any "unsafe" characters with `\xXY`, so we need to un-escape them to get the raw values back. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/decode-reader
branch
from
6c7277c
to
e358d13
Compare
Unix4ever
approved these changes
Jan 12, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 12, 2024
See: siderolabs/go-kmsg#9 This fixes lots of `\xab` issues, specifically in: * `talosctl dmesg` output * `taloscl dashboard` * embedded dashboard, including OAuth2 QR code display Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 18, 2024
See: siderolabs/go-kmsg#9 This fixes lots of `\xab` issues, specifically in: * `talosctl dmesg` output * `taloscl dashboard` * embedded dashboard, including OAuth2 QR code display Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit d5321e0)
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 2, 2024
See: siderolabs/go-kmsg#9 This fixes lots of `\xab` issues, specifically in: * `talosctl dmesg` output * `taloscl dashboard` * embedded dashboard, including OAuth2 QR code display Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit d5321e0)
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 2, 2024
See: siderolabs/go-kmsg#9 This fixes lots of `\xab` issues, specifically in: * `talosctl dmesg` output * `taloscl dashboard` * embedded dashboard, including OAuth2 QR code display Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit d5321e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/dev/kmsgescapes any "unsafe" characters with\xXY, so we need to un-escape them to get the raw values back.