Fix UUID to only return Middle Endian on SMBIOS Versions >= 2.6 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
previously approved these changes
Apr 14, 2021
|
@bnason would you mind re-pushing the change with the commit message conforming to conventional commits + DCO, e.g.: |
|
/approve |
bnason
force-pushed
the
uuid-fix
branch
2 times, most recently
from
2183818
to
9cebffa
Compare
Changes the conversion logic used to return the UUID. Now only converts to middle endian on smbios >= 2.6. Signed-off-by: Brandon Nason <brandon.nason@gmail.com>
rsmitty
approved these changes
Apr 22, 2021
smira
approved these changes
Apr 22, 2021
|
/lgtm |
smira
added a commit
to smira/sidero
that referenced
this pull request
Apr 22, 2021
See siderolabs/go-smbios#8 This pulls also other changes from `go-smbios` which add new memory information, but they're not used yet. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
added a commit
to smira/sidero
that referenced
this pull request
Apr 22, 2021
See siderolabs/go-smbios#8 This pulls also other changes from `go-smbios` which add new memory information, but they're not used yet. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
talos-bot
pushed a commit
to siderolabs/sidero
that referenced
this pull request
Apr 22, 2021
See siderolabs/go-smbios#8 This pulls also other changes from `go-smbios` which add new memory information, but they're not used yet. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to the UUID function to only convert to Middle Endian on SMBIOS Versions greater than or equal to 2.6.
I've also published patched copies of Sidero and Talos using this branch:
https://github.com/bnason/talos/tree/go-smbios-uuid-fix
https://github.com/bnason/sidero/tree/go-smbios-uuid-fix
I was able to successfully test this on 3 systems:
One interesting thing to note about system 2 is that before pxe booting, the system prints the UUID as 9402DE03-8004-0605-F806-D50700080009 while both iPXE and go-smbios report it as 03DE0294-0480-0506-F806-D50700080009.
More systems should probably be tested to ensure wide compatability.