New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide build instructions for NVIDIA kernel module #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
nvidia-poc
branch
3 times, most recently
from
December 22, 2021 21:31
8e65b01
to
8de7cee
Compare
smira
commented
Dec 22, 2021
@@ -9,8 +9,8 @@ steps: | |||
# sync with version and revision in build | |||
- url: https://github.com/containerd/containerd/archive/refs/tags/v1.5.8.tar.gz | |||
destination: containerd.tar.gz | |||
sha256: a41ab8d39393c9456941b477c33bb1b221a29b635f1c9a99523aab2f5e74f790 | |||
sha512: c769506ff6d98689c46ffee94d70ae00ef2f32e0daac1e631cbe8a587f67c7e4f83eb3895707362bdf46198b61823c99df1d8ca61095ab1415de5596f106fd07 | |||
sha256: 0890f7b0ee8e20a279a617c60686874b3c7a99e064adb2b38d884499b5284c43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once again GitHub changed hash for the archive behind the scenes
smira
force-pushed
the
nvidia-poc
branch
3 times, most recently
from
December 23, 2021 16:56
83c15f5
to
805efa5
Compare
smira
commented
Dec 23, 2021
@@ -44,6 +44,25 @@ steps: | |||
- name: docker | |||
path: /root/.docker/buildx | |||
|
|||
- name: build-nonfree-pull-request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only build non-free, never push it
Actual module is built in the CI, but never pushed to the registry. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
frezbo
approved these changes
Dec 24, 2021
Unix4ever
approved these changes
Dec 24, 2021
/m --ff |
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual module is built in the CI, but never pushed to the registry.
Fixes siderolabs/talos#4692
Signed-off-by: Andrey Smirnov andrey.smirnov@talos-systems.com