Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Use network information from guestinfo.metadata #6708

Closed
ErikLundJensen opened this issue Jan 5, 2023 · 2 comments
Closed

VMware: Use network information from guestinfo.metadata #6708

ErikLundJensen opened this issue Jan 5, 2023 · 2 comments

Comments

@ErikLundJensen
Copy link
Sponsor Contributor

Feature Request

Given a setup containing Cluster API with VMware (CAPV) and Talos (CABPT / CACPPT ) and IPAM InCluster then IP addresses can be allocated of pool of IP addresses.
The field addressesFromPools in VSphereMachineTemplate specify which pool to use.

CAPV generates the guestinfo.metadata with an IP address from the pool for each virtual machine, however, Talos does not read guestinfo.metadata.

The Talos implementation of integration with VMware platform should be like the nocloud implementation where guestinfo.metadata is used and injected into the virtual machine's network configuration.

Description

Here is a sample of guestinfo.metadata produced by CAPV:

instance-id: "vmware-test-controlplane-zhnhr"
local-hostname: "vmware-test-controlplane-zhnhr"
wait-on-network:
  ipv4: false
  ipv6: false
network:
  version: 2
  ethernets:
    id0:
      match:
        macaddress: "00:50:41:b3:71:44"
      set-name: "eth0"
      wakeonlan: true
      addresses:
      - "192.168.0.230/24"
      gateway4: "192.168.0.1"

The nocloud implementation of reading and using guestinfo.metadatacould be reused in the VMware platform.
metadata.go

Why is this needed?

See detailed explaination here IPAM support proposal

ErikLundJensen added a commit to ErikLundJensen/talos that referenced this issue Jan 10, 2023
ErikLundJensen added a commit to ErikLundJensen/talos that referenced this issue Jan 13, 2023
@ErikLundJensen
Copy link
Sponsor Contributor Author

The vmware metadata which is setup by CAPV is defined here:
https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/pkg/util/constants.go

@ErikLundJensen ErikLundJensen changed the title VMware: Use network infromation from guestinfo.metadata VMware: Use network information from guestinfo.metadata Jan 13, 2023
ErikLundJensen added a commit to ErikLundJensen/talos that referenced this issue Jan 21, 2023
ErikLundJensen added a commit to ErikLundJensen/talos that referenced this issue Jan 21, 2023
ErikLundJensen added a commit to ErikLundJensen/talos that referenced this issue Jan 24, 2023
Add VMware GuestInfo metadata to network configuration.

Closes siderolabs#6708

Signed-off-by: Erik Lund Jensen <info@erikjensen.it>
ErikLundJensen added a commit to ErikLundJensen/talos that referenced this issue Jan 24, 2023
Add VMware GuestInfo metadata to network configuration.

Closes siderolabs#6708

Signed-off-by: Erik Lund <info@erikjensen.it>
ErikLundJensen added a commit to ErikLundJensen/talos that referenced this issue Jan 25, 2023
Add VMware GuestInfo metadata to network configuration.

Closes siderolabs#6708

Signed-off-by: Erik Lund <info@erikjensen.it>
@ErikLundJensen
Copy link
Sponsor Contributor Author

Adding refernce to PR-6737

@smira smira closed this as completed in 230cfaf Mar 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant