Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bigger META values via INSTALLER_META environment variable #8186

Closed
smira opened this issue Jan 22, 2024 · 3 comments · Fixed by #8188
Closed

Support bigger META values via INSTALLER_META environment variable #8186

smira opened this issue Jan 22, 2024 · 3 comments · Fixed by #8188
Assignees
@smira

Comments

@smira
Copy link
Member

smira commented Jan 22, 2024

Talos support for compression of INSTALLER_META values to handle big META values which overflow kernel cmdline.
@smira smira self-assigned this Jan 22, 2024
@frezbo
Copy link
Member

frezbo commented Jan 22, 2024

Talos support for compression of INSTALLER_META values to handle big META values which overflow kernel cmdline.

doesn't kernel also has a limit on the length of the cmdline, i remember reading something similar

smira added a commit to smira/talos that referenced this issue Jan 22, 2024
@smira
fix: allow META encoded values to be compressed
07d5fa6 
Fixes siderolabs#8186

This is planned to be backported to Talos 1.6.3.

This allows to pass large META values (YAML for platform network
configuration) which might otherwise exceed the limit for kernel
command line params.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this issue Jan 22, 2024
Merged
@smira
Copy link
Member Author

smira commented Jan 22, 2024

Talos support for compression of INSTALLER_META values to handle big META values which overflow kernel cmdline.

doesn't kernel also has a limit on the length of the cmdline, i remember reading something similar

hmm... this is exactly what this sentence says, doesn't it?

@frezbo
Copy link
Member

frezbo commented Jan 22, 2024

Talos support for compression of INSTALLER_META values to handle big META values which overflow kernel cmdline.

doesn't kernel also has a limit on the length of the cmdline, i remember reading something similar

hmm... this is exactly what this sentence says, doesn't it?

i interpreted it differently, thinking this was overflowing some meta size limit

smira added a commit to smira/talos that referenced this issue Jan 23, 2024
@smira
fix: allow META encoded values to be compressed
e24d7c9 
Fixes siderolabs#8186

This is planned to be backported to Talos 1.6.3.

This allows to pass large META values (YAML for platform network
configuration) which might otherwise exceed the limit for kernel
command line params.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira added a commit to smira/image-service that referenced this issue Jan 23, 2024
@smira
feat: update Talos version
c603b11 
This includes a fix for compressed META.

See siderolabs/talos#8186

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this issue Jan 23, 2024
Merged
smira added a commit to smira/talos that referenced this issue Jan 24, 2024
@smira
fix: allow META encoded values to be compressed
c4d6f49 
Fixes siderolabs#8186

This is planned to be backported to Talos 1.6.3.

This allows to pass large META values (YAML for platform network
configuration) which might otherwise exceed the limit for kernel
command line params.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit e0dfbb8)
smira added a commit to smira/talos that referenced this issue Jan 24, 2024
@smira
fix: allow META encoded values to be compressed
815fef8 
Fixes siderolabs#8186

This is planned to be backported to Talos 1.6.3.

This allows to pass large META values (YAML for platform network
configuration) which might otherwise exceed the limit for kernel
command line params.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit e0dfbb8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow META encoded values to be compressed smira/talos
2 participants
@smira @frezbo