Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate siderolink-agent into talosctl cluster create #8392

Closed
Tracked by #8481
smira opened this issue Mar 5, 2024 · 0 comments · Fixed by #8482
Closed
Tracked by #8481

integrate siderolink-agent into talosctl cluster create #8392

smira opened this issue Mar 5, 2024 · 0 comments · Fixed by #8482
Assignees
@DmitriyMV

Comments

@smira
Copy link
Member

smira commented Mar 5, 2024 •
edited

Goal: make it easier to test SideroLink in automated way.

Steps:

  • make cmd/siderolink-agent Go importable
  • add a flag --with-siderolink to talosctl cluster create
  • if enabled, talosctl cluster create spawns talosctl siderolink-launch which internally imports siderolink-agent and starts it on the bridge address
  • use information from the Talos cluster state.yaml to hand out SideroLink peer addresses, etc.
  • if enabled, push SideroLink configuration to Talos (e.g. via extra kernel args)
  • if enabled, make apply-config in talosctl cluster create push over SideroLink address
  • add a new integration in Drone with siderolink enabled
@smira smira mentioned this issue Mar 21, 2024
Closed
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 21, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand.
40a85a9 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 21, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
ac55877 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 21, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
60f2003 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 21, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
c638d32 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 22, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
a0e2188 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 22, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
be2d33a 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 23, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
c97d96e 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 23, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
a614c7d 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 23, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
bc2f70a 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Mar 23, 2024
@DmitriyMV
chore: import siderolink as siderolink-launch subcommand
4b675ed 
This PR ensures that we can test our siderolink communication using embedded siderolink-agent.
If `--with-siderolink` provided during `talos cluster create` talosctl will embed proper kernel string and setup `siderolink-agent` as a separate process. It should be used with combination of `--skip-injecting-config` and `--with-apply-config` (the latter will use newly generated IPv6 siderolink addresses which talosctl passes to the agent as a "pre-bind").

Fixes siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV linked a pull request Apr 1, 2024 that will close this issue
chore: import siderolink as siderolink-launch subcommand. #8482
Merged
@DmitriyMV DmitriyMV mentioned this issue Apr 1, 2024
Closed
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Apr 1, 2024
@DmitriyMV
chore: enable "WG over GRPC" testing in siderolink agent tests
840f1c5 
Fixes siderolabs#8514
For siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV mentioned this issue Apr 1, 2024
Merged
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Apr 1, 2024
@DmitriyMV
chore: enable "WG over GRPC" testing in siderolink agent tests
15d3caa 
Fixes siderolabs#8514
For siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Apr 1, 2024
@DmitriyMV
chore: enable "WG over GRPC" testing in siderolink agent tests
0430f0c 
Fixes siderolabs#8514
For siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Apr 1, 2024
@DmitriyMV
chore: enable "WG over GRPC" testing in siderolink agent tests
fdf007c 
Fixes siderolabs#8514
For siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Apr 1, 2024
@DmitriyMV
chore: enable "WG over GRPC" testing in siderolink agent tests
791444f 
Fixes siderolabs#8514
For siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Apr 1, 2024
@DmitriyMV
chore: enable "WG over GRPC" testing in siderolink agent tests
f1ec7d4 
Fixes siderolabs#8514
For siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this issue Apr 1, 2024
@DmitriyMV
chore: enable "WG over GRPC" testing in siderolink agent tests
8dc4910 
Fixes siderolabs#8514
For siderolabs#8392

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DmitriyMV DmitriyMV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: import siderolink as siderolink-launch subcommand. DmitriyMV/talos
2 participants
@smira @DmitriyMV