fix: drop unpacked layers from containerd image store #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Dec 6, 2021
See containerd/cri#1543 Fixes siderolabs#4274 Fix is applied on two levels: * for Talos-initiated pulls, update API call * for Kubernetes-initiated pulls, update CRI plugin config Comparison of `/var` usage before/after, as reported by `talosctl mounts` (in GiB): | | before | after | |--------------|:------:|------:| | controlplane | 1.98 | 1.74 | | worker | 1.17 | 1.01 | It's hard to measure effect on pulls to system containerd, like `installer` image, as it's ephemeral, but it should also reduce space usage in `tmpfs`. Also fixes output of `talosctl mounts`. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
smira
force-pushed
the
drop-unpacked-layers
branch
from
d12f99a
to
8f3e1a4
Compare
|
/m --ff |
frezbo
pushed a commit
to frezbo/talos
that referenced
this pull request
Dec 7, 2021
Fixes siderolabs#4653 This fixes an issue when `etcd` get stuck in `Pre` state so that even `bootstrap` request doesn't kill it. This looks like a cluster which fails to bootstrap itself and get stuck on reboot. Even though `Watch()` aborts on cancel, channel receive will block forever as no events are delivered. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See containerd/cri#1543
Fixes #4274
Fix is applied on two levels:
Comparison of
/varusage before/after, as reported bytalosctl mounts(in GiB):(this is on freshly bootstrapped but otherwise empty cluster)
It's hard to measure effect on pulls to system containerd, like
installerimage, as it's ephemeral, but it should also reduce spaceusage in
tmpfs.Also fixes output of
talosctl mounts.Signed-off-by: Andrey Smirnov andrey.smirnov@talos-systems.com
This change is