Expanded Cilium deployment documentation #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Feb 18, 2022
Ulexus
reviewed
Feb 18, 2022
Ulexus
approved these changes
Feb 18, 2022
|
@SixFive7 can you sign off the commit with |
|
All commits should be signed now except those done through the web ui by clicking the "accept suggested changes" button. Turns out this is not yet possible: todogroup/gh-issues#50 |
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Feb 18, 2022
Update cilium docs Co-authored-by: Jori Huisman <6650122+SixFive7@users.noreply.github.com> supercededs: siderolabs#5012 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Feb 18, 2022
Update cilium docs Co-authored-by: Jori Huisman <6650122+SixFive7@users.noreply.github.com> supersedes: siderolabs#5012 Signed-off-by: Noel Georgi <git@frezbo.dev>
|
/ok-to-test |
Expanded Cilium deployment documentation Co-authored-by: Noel Georgi <git@frezbo.dev> Signed-off-by: Noel Georgi <git@frezbo.dev>
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What?
Expanded a little on the Talos specific Cilium deployment details.
Why?
There are some gotchas when deploying Cilium onto Talos that takes time to figure out if not documented.
Related issues mentioned in the documentation
#4109 GCP ILB support / support scope local routes to be configured
#4212 add Node.PodCIDRs to the k8s nodeadress filter
#4654 Kernel default values (sysctl)
#4756 Cilium Documentation Generates Clusters Without a CNI
#4836 Kubespan and Cilium compatiblity: etcd is failing
#4863 Cilium on talos "aoe: packet could not be sent on *. consider increasing tx_queue_len"
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)This change is