Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix wrong capability name #7473

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 13, 2023

It's CAP_SYS_BOOT, not CAP_BOOT.

Pull Request

What? (description)

Why? (reasoning)

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

@frezbo
Copy link
Member

frezbo commented Jul 13, 2023

Thanks for the PR, though from linux point of view CAP_BOOT is correct, thought multiple libraries uses it inter-changeably.

@frezbo
Copy link
Member

frezbo commented Jul 13, 2023

/ok-to-test

@flokli
Copy link
Contributor Author

flokli commented Jul 13, 2023

Hmmm, the Talos changelog and machinery also call it CAP_SYS_BOOT: https://github.com/search?q=repo%3Asiderolabs%2Ftalos%20cap_sys_boot&type=code

@frezbo
Copy link
Member

frezbo commented Jul 13, 2023

Hmmm, the Talos changelog and machinery also call it CAP_SYS_BOOT: https://github.com/search?q=repo%3Asiderolabs%2Ftalos%20cap_sys_boot&type=code

oh it read the PR wrong, I meant SYS_BOOT and CAP_SYS_BOOT are equivalent. not CAP_BOOT 😅

It's CAP_SYS_BOOT, not CAP_BOOT.

Signed-off-by: Florian Klink <flokli@flokli.de>
Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
@smira
Copy link
Member

smira commented Jul 19, 2023

/ok-to-test

Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@smira
Copy link
Member

smira commented Jul 19, 2023

/m

@talos-bot talos-bot merged commit b84277d into siderolabs:main Jul 19, 2023
19 of 20 checks passed
@flokli flokli deleted the CAP_SYS_BOOT branch July 19, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants