feat: imager overlay #8377
Merged
feat: imager overlay #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
force-pushed
the
feat/imager-overlay
branch
from
74d5c66
to
2d2ce53
Compare
smira
reviewed
Feb 28, 2024
frezbo
force-pushed
the
feat/imager-overlay
branch
from
2d2ce53
to
94c8409
Compare
smira
approved these changes
Feb 29, 2024
pkg/imager/imager.go
Outdated
| @@ -251,8 +327,8 @@ func (i *Imager) buildCmdline() error { | |||
| cmdline.SetAll(p.KernelArgs().Strings()) | |||
|
|
|||
| // board kernel args | |||
| if i.prof.Board != "" { | |||
| var b runtime.Board | |||
| if i.prof.Board != "" && !quirks.New(i.prof.Version).SupportsOverlay() { | |||
There was a problem hiding this comment.
I guess this would break /promote integration-images as make sbcs would no longer work?
not a big deal for me, but we should probably remove it from the Makefile?
There was a problem hiding this comment.
yeh, i'll keep it commented
frezbo
force-pushed
the
feat/imager-overlay
branch
from
94c8409
to
2ff56da
Compare
Support overlays for imager. The `Install` interface is not wired yet, it will be done as a different PR. This should be a no-op for existing imager. Part of: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
force-pushed
the
feat/imager-overlay
branch
from
2ff56da
to
8125e75
Compare
|
/m |
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Feb 29, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Feb 29, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Feb 29, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 1, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 1, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 2, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 3, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 7, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 8, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 11, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
Mar 12, 2024
Implement `Install` for imager overlays. Also add support for generating installers. Depends on: siderolabs#8377 Fixes: siderolabs#8350 Fixes: siderolabs#8351 Fixes: siderolabs#8350 Signed-off-by: Noel Georgi <git@frezbo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support overlays for imager.
The
Installinterface is not wired yet, it will be done as a different PR.This should be a no-op for existing imager.
Part of: #8350