GenerateIfExpired ignores an error #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoheimuta
commented
Jul 9, 2018
| func (c *Client) setTokenHeader(r *http.Request) error { | ||
| _, err := c.Token.GenerateIfExpired() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Behavior changes. The default may be better to ignore errors as before.
|
Thanks for the PR. In hindsight it wasn't the best decision to ignore the error, but currently if token generation fails then it will just return 401, and the token will try and regenerate on the next push. As you picked up this PR would change the behaviour so it's probably better to leave as is. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to return an error if GenerateIfExpired fails.