Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rpc client bug #112

Closed
wants to merge 2 commits into from
Closed

fix rpc client bug #112

wants to merge 2 commits into from

Conversation

yincongcyincong
Copy link

when i user rpc to ios push, some error will happen:

err gob: type payload.Payload has no exported fields

err gob: type not registered for interface: payload.aps

err gob: type not registered for interface: payload.Payload

so i fix the bug

@coveralls
Copy link

coveralls commented Aug 3, 2018

Coverage Status

Coverage increased (+0.08%) to 91.837% when pulling b55f8ad on yincongcyincong:master into c6554af on sideshow:master.

@sideshow
Copy link
Owner

sideshow commented Sep 7, 2019

Its been a while since this PR but I think the fix for this (rather than me merging as it would change behaviour) is to just use your own payload class. The payload can be anything so long as it returns bytes containing the JSON-encoded payload. So if you make your own notification package as per your code, it should just work.

@sideshow sideshow closed this Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants