Support iOS 12 Critical Alerts #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created an issue for book-keeping sake. Closes #114. |
sideshow
requested changes
Aug 10, 2018
| @@ -16,7 +16,7 @@ type aps struct { | |||
| Category string `json:"category,omitempty"` | |||
| ContentAvailable int `json:"content-available,omitempty"` | |||
| MutableContent int `json:"mutable-content,omitempty"` | |||
| Sound string `json:"sound,omitempty"` | |||
| Sound interface{} `json:"sound,omitempty"` | |||
There was a problem hiding this comment.
Are you able to make this a sound struct similar to what I did for the alert struct.
That way for consistency with the existing they could either use like this:
payload.NewPayload().SoundName("..").SoundVolume("..")
or like this:
payload.NewPayload().Sound(map[string]interface{}{ .. })
| @@ -84,7 +84,7 @@ func (p *Payload) UnsetBadge() *Payload { | |||
| // This will play a sound from the app bundle, or the default sound otherwise. | |||
| // | |||
| // {"aps":{"sound":sound}} | |||
| func (p *Payload) Sound(sound string) *Payload { | |||
| func (p *Payload) Sound(sound interface{}) *Payload { | |||
There was a problem hiding this comment.
This can still stay as interface, that way it can accept either a string, map or the sound struct.
|
@sideshow Thanks for the review, I've went ahead and added a SoundName/SoundVolume interface. Yes, we're currently using this library, thanks for making it available! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aps sound field in the APNS payload can now be a dictionary in order to send critical alerts for iOS 12 devices.
You can read about it here.
These changes add support for that as well as a test case.
cc @froodian