parse pkcs8 if pkcs1 fails #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @ostlerc |
|
Sure. I'll try to get to it in a somewhat timely manner. |
mocked out dependencies
i'm not entirely sure why we do this, but hopefully it's okay to go with the more idiomatic testing strategy here.
|
I added a test for the private function parsePrivateKey. But looks like you get a race condition if you switch your test package name to be the same as the actual package. This is confusing to me, and honestly taking more time than I wanted. So i'll close this PR and if you want this feature you can look at it if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the pkcs8 certificate. This fixes parsing the certificate in this scenario.