Wallet balances refetched too much

[aomafarag]

Goal

Optimize wallet setup and balances fetching.

Context

Currently, we re-setup the wallet whenever the wallet modal is opened. This action resets the wallet, which involves resetting its balances and re-fetching them. As a result, the WithdrawDAIPanel, whose current state and title is displayed via a computed property that depends on the amount of DAI in VAT, collapses and expands whenever the wallet modal is opened (see Assets). Additionally, whenever the withdraw button is clicked, the animation due to AnimatedNumber is rerun (see Assets). I guess this has to do with the fact that BaseButton treats the loading and non-loading cases as two separate templates.

Assets

perf.mp4

Tasks

• Suggest a modification to the store logic that allows wallet balances to persist when re-fetching isn't necessary.
• Modify BaseButton so that it switches between the loading and non-loading state in a single template (if this is why the animation is rerun)
• Implement that suggestion once approved.