Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support reth simulations #525

Closed
wants to merge 2 commits into from
Closed

Feat: Support reth simulations #525

wants to merge 2 commits into from

Conversation

KirillDogadin-std
Copy link
Contributor

Closes #524

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • issue checkboxes are all addressed
  • manually checked my feature / not applicable
  • wrote tests / not applicable
  • attached screenshots / not applicable

@KirillDogadin-std
Copy link
Contributor Author

Seems like the oracle is still not functional (price is 0). Any action required?

@valiafetisov
Copy link
Contributor

valiafetisov commented Nov 7, 2022 •
edited
Loading

Any action required?

Let's wait for the #512 to be merged so that we can also generically overwrite oracle prices for the tests to pass. Or can you already do this using file methods now?

@KirillDogadin-std
Copy link
Contributor Author

let's wait.

@LukSteib LukSteib closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valiafetisov valiafetisov valiafetisov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: remove reth from unsupported collaterals
3 participants
@KirillDogadin-std @valiafetisov @LukSteib