Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conceptualise partial swapping #534

Open
5 tasks
valiafetisov opened this issue Nov 14, 2022 · 0 comments
Open
5 tasks

Conceptualise partial swapping #534

valiafetisov opened this issue Nov 14, 2022 · 0 comments

Comments

@valiafetisov
Copy link
Contributor

valiafetisov commented Nov 14, 2022

Goal

A developer is able to implement the desired feature.

Context

Currently, we only allow partial bidding on collateral auctions when participating with your own DAI. But it's also possible to do so with swap-like transaction using callee. The only technical problem (and the advantage for the user) is that every time the bid amount is changed, the market unit prices will also change (and we might also need to refetch them in order to display correct numbers).

Note:

Assets

Latest mock: https://whimsical.com/makerdao-new-collateral-BT3LASEF2aRAQEuav79UUw

MakerDAO new collateral@2x (9)

Requirements

  • The proposal for the first iteration of this feature is to limit swap amount choices to a few predefined "probes" per market (but in the future we want to provide user with the regular input)
  • UI-wise we want to show those options in a table, so the user can full overview of all "probed" prices and can choose other markets/amounts
    • the same component should be used to show those numbers inside Market unit price expandable block as well as in the Amount to swap expandable (with same tooltips, but with different main values: marketUnitPrice vs netTransactionProfit)
  • The bot will need to have not just suggestedMarketId, but also suggested swap amount

Tasks

  • Conceptualise implementation/refactoring
    • Outline what needs to be done
    • Outline new vs old data structures
    • Outline new bot behaviour
    • Propose roadmap, ie issue(s) to get there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant