Fix build issues on Windows #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidoh
approved these changes
Feb 16, 2018
|
Looks great! |
sidoh
added a commit
that referenced
this pull request
May 4, 2018
* Fix build issues on Windows (#225) * Added 'Night' button (#226) * Improve state debugging (#228) nice debugging code to help debug state changes * Switched to using library ESP8266WebServer (#231) * Switched to using library ESP8266WebServer * Refactored to share authentication logic, * Add LED status to indicate wifi condition and packet handling (#241) * LED status feature * Switch to new git for wifimanager * LED flashing class * Added F(), fixed tabs/{}, enum class * re-generate webpage * disable group state debugging * Enable night mode for all types * Handle inconsistency on saturation/temp on v2 types (#227) * Handle inconsistency on saturation/temp on v2 types * Changed temp/sat to be optional, refacted for settings now in formatters * When not mode switching, switch to white on update temp * Added debug to print version number * Reverted back to no longer using state for saturation changes * Fixed refactored union member name (Data to rawData) * remove commented out code (#243) * Remove outdated instruction * No longer need to use beta version of Arduino SDK * whitespace * Use consistent flag * Add method to check if bulb is on * Clear night mode when changing status * Debug printing * Check if bulb is on before applying state * Better night mode handling * well, that was silly * fix javascript error * add options to include device_id, device_type, and group_id in state updates * Acknowledgement :) * document new fields * Added UI support for enable_solid_led * Implemented support for blinking vs. solid LED * Updated README to reflect enable_solid_led and general improvements. * Fix next/prev mode for RGBW * Use correct name for white mode command (fixes #249) * styling * Measure R/G/B relative distance instead of distance from max (addresses #258) * No transitivity with abs * Updated UI and LED support * Fix wrong parsed command for RGBW (fixes #260) * Fixed MQQT to MQTT! * Fixed "tab-MQTT" to "tab-mqtt" for consistent style * add generated webpage * Add correct default * De-select unselectable groups when changing modes * regen page * Throw alert when group not selected * put nav in navbar * Shorten tab title * Keep track of state for increment commands that have hard boundaries * comments * Update UI screenshot * dont set content length manually * more accurate hints for config fields * set cct bulb id correctly on on/off command ignore group id when setting bulb id in favour of defined group id against the on/off command code * dont set content length manually 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for building on Windows. Sorry about the yanking of the PR's, but I had some issues with my repository that I needed to clean, and I took advantage of that to change to my main account (I forgot I was using a test account!)