Fix change of LED pin setting #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to
ledPinwould only have an effect ifinversewas also change (and vice versa)....
I found this while trying to figure out why I was unable to completely turn off the LED. It turns out that my board has two LEDs and I was observing the wrong one. The one I was trying to silence would actually light up every time a packet was sent because it is controlled by GPIO16. Moving CE from GPIO16 to GPIO4 solved my issue.
https://lowvoltage.github.io/2017/07/09/Onboard-LEDs-NodeMCU-Got-Two