Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal for a startup message #51

Merged
merged 3 commits into from
Mar 13, 2022
Merged

proposal for a startup message #51

merged 3 commits into from
Mar 13, 2022

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Mar 9, 2022

Following the discussion in #16 I propose the following startup message:

> library(sidora.core)

   / \    Pandora contains many samples that are ethically
  / | \   and/or culturally sensitive and are therefore
 /  *  \  off-limits for many analyses.

They are indicated in the column Ethically_culturally_sensitive of TAB_Sample. Make sure to exclude these samples depending on your application and permissions!

Opinions, @jfy133 and @ivelsko?

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, suggested tweak (although makes it a bit long).

I wonder if we should make it 'agree to continue' (and turn off with some .Renv setting) 🤔

R/zzz.R Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #51 (79ae2a6) into master (d003bef) will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #51      +/-   ##
=========================================
- Coverage    9.39%   8.91%   -0.49%     
=========================================
  Files          11      12       +1     
  Lines         330     359      +29     
=========================================
+ Hits           31      32       +1     
- Misses        299     327      +28     
Impacted Files Coverage Δ
R/zzz.R 14.28% <ø> (ø)
R/utils_general.R 0.00% <0.00%> (ø)
R/dataprep_table_formatting.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d003bef...79ae2a6. Read the comment docs.

@nevrome nevrome merged commit 8e4c3d9 into master Mar 13, 2022
@nevrome nevrome deleted the startupmessage branch March 13, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants