Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dplyr behaviour for appending suffixes upon join seems to have changed #68

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Mar 14, 2023

@aidaanva told me that she can not access TAB_Analysis any more.

analysis <- get_df("TAB_Analysis", con)

[sidora.core] loading analysis may take a while, please be patient.
Error in `.data[["Id.x"]]`:
! Column `Id.x` not found in `.data`.

I can reproduce this. My guess is, that this is caused by a change in dplyr 1.1.0. At least their changelog states "Joins have been completely overhauled", so that could be it.

I removed the offending and now apparently unnecessary line and made dplyr 1.1.0 mandatory for sidora.core. There are a number of more gentle solutions we could consider. Happy to think about it again tomorrow, but I quickly wanted to make you aware of the issue and provide and intermediate fix for Aida.

@nevrome
Copy link
Member Author

nevrome commented Mar 15, 2023

I replaced my initial solution with something more verbose, which should work for both old and new dplyr/dbplyr versions. Just to ensure none of our dependencies have to suffer.

@jfy133
Copy link
Member

jfy133 commented Mar 23, 2023

CHANGELOG update missing, but otherwise OK

@nevrome nevrome merged commit 71aaefc into master Mar 28, 2023
@nevrome nevrome deleted the dplyr1.1.0fix branch March 28, 2023 14:09
@nevrome nevrome restored the dplyr1.1.0fix branch March 28, 2023 14:12
@nevrome nevrome deleted the dplyr1.1.0fix branch March 28, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants