Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deque from denque to Js-sdsl Deque #1629

Open
ZLY201 opened this issue Sep 8, 2022 · 7 comments
Open

Migrate deque from denque to Js-sdsl Deque #1629

ZLY201 opened this issue Sep 8, 2022 · 7 comments
Labels
dependencies Pull requests that update a dependency file performance

Comments

@ZLY201
Copy link

ZLY201 commented Sep 8, 2022

Hey! I'm the developer of Js-sdsl. Official website: https://js-sdsl.github.io/.

Now, we published the version 4.1.4.

I see you are using denque.

In benchmark, we have confirmed that Js-sdsl is several times faster than denque and nearly equal to Array.push in the case of push elements.

We would like to invite you to migrate deque related functions to Js-sdsl v4.1.4 and I am willing to submit a pull request for this change.

Looking forward to your reply! :D

@sidorares
Copy link
Owner

Thanks for the offer, I'll try to evaluate Js-sdsl!
It would be interesting to see real world impact on performance with some typical patterns of connection / prepared statements / pool use.

@ZLY201
Copy link
Author

ZLY201 commented Sep 11, 2022

Hey, I done th migrate.

See #1633.

How can I know the result about benchmark?

@ZLY201
Copy link
Author

ZLY201 commented Oct 2, 2022

@js-sdsl/deque published!

@sidorares
Copy link
Owner

@ZLY201 I don't want to change core functionality that already works fine without convincing benchmarks ( in the context of drivers use case ). I believe Js-sdsl is more performant than denque but need to see some visible difference (with all other components factored in). if its below statistical error not worth the change

It's not that I'm against this change, just until there is a good benchmark its a low priority for me

@ZLY201
Copy link
Author

ZLY201 commented Nov 24, 2022

@ZLY201 I don't want to change core functionality that already works fine without convincing benchmarks ( in the context of drivers use case ). I believe Js-sdsl is more performant than denque but need to see some visible difference (with all other components factored in). if its below statistical error not worth the change

It's not that I'm against this change, just until there is a good benchmark its a low priority for me

Thanks to your reply!

We are trying to find a good way to test the performance of Js-sdsl in MySQL like database connections, including Redis and MongoDB.

This will be our main work in the next stage. So make this progress to be pending is reasonable.

@trasherdk
Copy link

@ZLY201 you got your definitions wrong
image

It's stack - first in last out, as in push pop
and queue first in first out, as in push shift.

@ZLY201
Copy link
Author

ZLY201 commented Nov 27, 2022

@ZLY201 you got your definitions wrong image

It's stack - first in last out, as in push pop and queue first in first out, as in push shift.

Sorry about that, I got it wrong. Thanks for reminding me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file performance
Projects
None yet
Development

No branches or pull requests

3 participants