feat(react): add vitest #1017
Merged
feat(react): add vitest #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleroux
previously approved these changes
Feb 21, 2024
packages/react/src/tests/undefined-error/undefined-error.spec.js
Outdated
Show resolved
Hide resolved
nuke-ellington
approved these changes
Feb 21, 2024
danielleroux
added
the
pull request affects patch version
danielleroux
added a commit
to danielleroux/ix
that referenced
this pull request
Feb 22, 2024
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn test) were run locally and passedyarn visual-regression) were run locally and passednpm lint) was run locally and passedNote: Tests have been added for the issues #944 and #945. Since the fix for these two hasn't been merged yet the tests of this branch will fail. So this PR is dependant on the merge of PR #1001.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: N/A
React components can now be tested with Jest.
What is the new behavior?
React components could not be tested.
Does this introduce a breaking change?
Testing
Manual testing of the relevant parts.
Other information
I decided to choose babel-jest over ts-jest. The reason is that babel-jest turned out to be easier to setup for me in this specific case.